[gstreamer-bugs] [Bug 590768] GstPulseSrc should allow swapping the device used by the stream

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=590768

  GStreamer | gst-plugins-good | Ver: git

Jonathan Tellier changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139956|0                           |1
        is obsolete|                            |




------- Comment #7 from Jonathan Tellier  2009-08-13 14:06 UTC -------
Created an attachment (id=140662)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=140662&action=view)
Fixed patch

> That was not the point, it was about %d and %s being in wrong order.

Oh, I see! Well actually, it's the parameters who were in the wrong order. I've
put it back then.

> You could avoid the double dup() and the lock() in case pulsesrc->stream is
> NULL. I would do it the same way it was done before.

I don't know if I understand you correctly, but I don't think we can avoid the
lock(). What if there's a race condition in which one thread is creating the
stream and the other one is checking if it's NULL?

Regarding the double dup(), I've made some small modification which gets rid of
it. 


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=590768.