[gstreamer-bugs] [Bug 589991] [queue] limited error handling might cause pipeline appearing to hang

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=589991

  GStreamer | gstreamer (core) | Ver: git

Mark Nauwelaerts changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139370|accepted-commit_after_freeze|committed
               Flag|                            |
 Attachment #139937|accepted-commit_after_freeze|committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.25




------- Comment #5 from Mark Nauwelaerts  2009-08-06 11:46 UTC -------
commit 3f0e4bd6f69067907bed6d3b07f41bb64b9c146f
Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Tue Jul 28 12:03:36 2009 +0200

    queue: add unit test

    Make a downstream element return an error after upstream has already
    put all data into queue (including EOS).  As such, upstream
    will not be around to pick up the error, so it is up to queue to
    act appropriately.  See #589991.

    Note there may be downstream fatal errors (e.g. negotiation) that do
    not warrant an error message already having been posted.

commit 3352c5d97042b21850439df2ca475c46c39a164b
Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Thu Aug 6 13:29:29 2009 +0200

    queue: post error message when pausing task

    If downstream returns error and upstream has already delivered
    everything (including EOS) and will no longer be around to find
    out that we paused (and why), post error message.  Fixes #589991.


And btw also for queue2 in -base:

commit ff998f24dbba934abd6402dafbe809cdf9dea466
Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Thu Aug 6 12:18:36 2009 +0200

    queue2: post error message when pausing task if so appropriate

    If a downstream element returns an error while upstream has already
    put all data into queue2 (including EOS), upstream will no longer
    chain into queue2, so it is up to queue2 to perform some
    EOS handling / message posting in such cases.  See #589991.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=589991.