[gstreamer-bugs] [Bug 590941] New: gst_pad_get_caps does unneded caps copies

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=590941

  GStreamer | gstreamer (core) | Ver: git
           Summary: gst_pad_get_caps does unneded caps copies
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ensonic at sonicpulse.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


gst_pad_get_caps (and therefore also gst_pad_peer_get_caps) promisses to return
writable caps. To ensure that it copies caps in most cases. This has two bad
side-effects:
* copying is often not needed (e.g. when using the caps to calculating an
intersection)
* when caps are copied we cannot compare pointers to benefit from quickly
leaving some operations

The attached patch adds variants that don't copy and makes use of them in core.
I am not entierly happy with the naming. Any ideas?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=590941.