[gstreamer-bugs] [Bug 590919] gst_util_uint64_scale_int() and friends don't round

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=590919

  GStreamer | gstreamer (core) | Ver: git




------- Comment #11 from Sebastian Dröge  2009-08-11 06:31 UTC -------
Looks good at first glance. Could you transform your validation code to a unit
test in tests/check/gst/gstutils.c? It's fine to use GMP there as long as you
also add a configure check and only compile the GMP code when GMP is available.
Also it would be nice to have a deterministic test additional to the random
number multiplication, i.e. some hardcoded integer multiplications.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=590919.