[gstreamer-bugs] [Bug 590768] GstPulseSrc should allow swapping the device used by the stream

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=590768

  GStreamer | gst-plugins-good | Ver: git




------- Comment #6 from Marc-Andre Lureau  2009-08-13 09:45 UTC -------
(In reply to comment #4)
> > What do you need the pa_stream for?
> 
> An application that is using this new functionality will most likely want to
> interact with the pa_stream in order to work properly. For instance, it might
> want to call pa_stream_set_moved_callback() to see if the device switching went
> well. Exposing the pa_stream is the simplest way I found of addressing such an
> issue, but I'm open to suggestions.
> 

Right. Maybe you should have split the patch and say that.

> > "Changing device of stream %d to %s", pulsesrc->device, stream_index);
> >                            ^^^^^^^^
> > this is bogus.
> 
> Well, it was useful to me when I was debugging, but I can always remove it.
> 

That was not the point, it was about %d and %s being in wrong order.

> > Also, perhaps pulsesrc->device should be updated only when the moving is
> > successful, dunno.
> 
> Yeah, that makes sense. I'll change that too.
> 

I don't know if it's a common way in gstreamer - perhaps properties are just
not the right interface for that.

You could avoid the double dup() and the lock() in case pulsesrc->stream is
NULL. I would do it the same way it was done before.

otherwise, the patch looks ok to me


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=590768.