[gstreamer-bugs] [Bug 593068] New: Disarray in directsoundsrc/directdrawsink

[GStreamer (bugzilla.gnome.org)]

http://bugzilla.gnome.org/show_bug.cgi?id=593068

           Summary: Disarray in directsoundsrc/directdrawsink
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: lrn1986 at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


--- Comment #0 from LRN <lrn1986 at gmail.com> 2009-08-25 19:58:34 UTC ---
Created an attachment (id=141681)
Direct* stuff fixes

1) Checks for dsound.h (which is included from DirectX SDK) without using
DIRECTSOUND_CFLAGS (which specifies -I path for DirectX SDK)
2) Uses separate DIRECTSOUND_CFLAGS and DIRECTDRAW_CFLAGS with the same
contents (-I path for DirectX SDK)
3) There are unused variable and label in directdrawsink.c

Patch is attached:
1) Use custom compile/link check for directsound (instead of generic compile
and generic link check), with proper include path
2) Use one DIRECTX_CFLAGS for both plugins
3) Remove unused variable and unused label from directdrawsink.c

-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.