[gstreamer-bugs] [Bug 593068] Disarray in directsoundsrc/directdrawsink

[GStreamer (bugzilla.gnome.org)]

http://bugzilla.gnome.org/show_bug.cgi?id=593068


Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julien.isorce at gmail.com


--- Comment #1 from Julien Isorce <julien.isorce at gmail.com> 2009-08-26 00:03:36 UTC ---
Hi,

"3) Remove unused variable and unused label from directdrawsink.c"
---
 configure.ac                        |   55 ++++++++++++++++++++++++++---------
 sys/directdraw/Makefile.am          |   24 +++++++-------
 sys/directsound/Makefile.am         |   24 +++++++-------
 sys/directsound/gstdirectsoundsrc.c |    8 -----
 4 files changed, 65 insertions(+), 46 deletions(-)
"

According to your patch, I think this is directsoundsrc.c and not
directdrawsink.c
?

And yes there is no "dsound.h" and "ddraw.h" in the official mingw-win32-api
package (see comment #22) http://bugzilla.gnome.org/show_bug.cgi?id=344129)
But there is a libddraw.lib in the official mingw-win32-api package (Yes it's
weird).

Withtout this patch those plugins cannot be build with the current Makefile.am
files in current git.
So I am ok with this patch.

For a later improvement, about directdrawsink/Mafile.am, as it exists always
libddraw.a, maybe it can be used with the ddraw.h file in DXSDK_DIR (this var
is set when installing the microsoft directx SDK). I am not sure if this
libddraw.a is compatible with the ddraw.h header in DXSDK_DIR,
can you check that ?

About directsoundsrc and directsoundsink the following bug has to be
considered:
http://bugzilla.gnome.org/show_bug.cgi?id=584980

-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.