[gstreamer-bugs] [Bug 585733] New: Wrong #include order in gstsegment.c

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=585733

  GStreamer | gstreamer (core) | Ver: git
           Summary: Wrong #include order in gstsegment.c
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: trivial
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: lrn1986 at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


GCC complains:
In file included from gst_private.h:28,
                 from gstsegment.c:25:
../config.h:311:1: error: "__MSVCRT_VERSION__" redefined
In file included from
c:\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/math.h:20,
                 from gstsegment.c:23:
c:\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/_mingw.h:213:1:
error: this is the location of the previous definition

This happens because gstsegment.c includes <math.h> before it includes
"gst_private.h". <math.h> pulls <_mingw.h>, and <_mingw.h>, seeing that
__MSVCRT_VERSION__ is not defined, defines it. Then "gst_private.h" pulls
config.h, which redefines __MSVCRT_VERSION__


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=585733.