[gstreamer-bugs] [Bug 595231] [pulsesink] Lowers volume after every new track

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=595231
  GStreamer | gst-plugins-good | 0.10.15

--- Comment #26 from Sebastian Dröge <slomo at circular-chaos.org> 2009-10-17 15:07:21 UTC ---
(In reply to comment #24)
> (In reply to comment #21)
> > Also, shouldn't volume_set and mute_set be set to FALSE after
> > pa_context_set_sink_input_volume()?
> 
> Not necessary. We only ever set those flags *before* the stream is setup --
> where we reset them again. While the stream is established the flags are not
> used at all anymore, are hence neither set, nor reset.

Not really, they're also set in gst_pulsesink_set_volume(), which is called
whenever the "volume" property is set (and the same for mute of course).

(In reply to comment #22)
> (In reply to comment #19)
> > Hm, shouldn't the volume setting in pa_stream_connect_playback() go away and be
> > replaced by pa_context_set_sink_input_volume()? Because former is relative
> > volume and latter absolute...
> 
> Yes and no. Even worse than setting the volume is setting the volume
> asynchronously in two steps. 
> 
> The proper fix for this is that we use a new flag I just added to PA which
> allows clients to select whether they want to specify relative or absolute
> volumes. For now I'd like to leave the current logic where the volume before
> and after stream setup can mean something different. (which they can anyway,
> since before the stream setup we don't know anything about the device and the
> volume capabilities of the device, but afterwards we do)
> 
> I'll prep a patch for gst as soon as this new flag is stabilizied.

Wouldn't it be better then to *not* set the mute/volumes in stream setup and
only afterwards? Otherwise the volume property has two different meanings,
depending on the current state.... and that's not really nice.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.