[gstreamer-bugs] [Bug 598771] Fix build without pango

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=598771
  GStreamer | gst-plugins-base | git

Felipe Contreras <felipe.contreras> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |UNCONFIRMED

--- Comment #5 from Felipe Contreras <felipe.contreras at gmail.com> 2009-10-17 20:45:21 UTC ---
(In reply to comment #3)
> > build: don't fail with old pango versions 
> > Somebody forgot that 'pangocairo >= 1.15.4' can fail.
> 
> Hrm, not quite sure I understand what the exact problem is here. Maybe the real
> problem is rather that gsttextoverlay.c uses #if HAVE_FOO_BAR where it should
> be using #ifdef HAVE_FOO_BAR ?
> 
> I think I'll just bump the pango requirements here btw and get rid of those
> ifdefs anyway.

Read 'man pkg-config':
If a module is missing or has the wrong version, by default configure will
abort  with a message.

If we don't want to abort, we need to provide an "action if not found".

> > build: avoid pango version check if it's not there
> 
> That makes sense, but wouldn't be needed any longer if the reqs get bumped.

That's unnecessary, but meh.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.