[gstreamer-bugs] [Bug 623104] [queue2] might create short buffer in get_range

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623104
  GStreamer | gstreamer (core) | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2010-06-29 10:47:53 UTC ---
I don't think that's true. gst_queue2_create_read() first calls
gst_queue2_have_data(), which checks if there's a chunk with the requested
offset and length. If there is the fread() must succeed, if queue2 is EOS
fread() will return the remaining number of bytes.

But a) the fseeks shouldn't be done if offset is after the EOS position and b)
there should be an assertion below fread() to check that the read length is
equal to the requested length unless queue2 is EOS.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.