[gstreamer-bugs] [Bug 619292] [API] bytewriter: add mark stacking functions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=619292
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161643|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-05-21 14:24:47 UTC ---
Review of attachment 161643:
 --> (https://bugzilla.gnome.org/review?bug=619292&attachment=161643)

::: libs/gst/base/gstbytewriter.h
@@ +47,3 @@
+
+  /*< private >*/
+  GArray *marks;

Sadly I don't think we can do this, because we allow allocation of byte writers
on the stack and "forgot" to add padding to these structs. Guess we need a
GstChunkWriter class or so (which could just keep track of the chunks and
return/init a byte writer to write into as chunk? Another thing we could have
done if we had padding - allow for a 'parent' byte writer..)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.