[gstreamer-bugs] [Bug 626618] jpegparse doesn't handle APP12 marker

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626618
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174666|none                        |needs-work
             status|                            |

--- Comment #45 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-11-19 15:07:41 UTC ---
Review of attachment 174666:
 --> (https://bugzilla.gnome.org/review?bug=626618&attachment=174666)

Looks good in general. To be sure, you only refactored the app1 code out of the
switch and also extracted the post_metadata code. There are no other changes?

::: gst/jpegformat/gstjpegparse.c
@@ +519,3 @@
+static inline void
+post_metadata (GstJpegParse * parse, guint size, guint8 * data,
+    GstTagList * (*TagFunc) (const GstBuffer * buff))

tiny nitpick, we would name "TagFunc" -> "tag_func"
also what about naming this function "extract_and_post_tags"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.