[gstreamer-bugs] [Bug 626618] jpegparse doesn't handle APP12 marker

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626618
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174667|none                        |needs-work
             status|                            |

--- Comment #46 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-11-19 15:15:27 UTC ---
Review of attachment 174667:
 --> (https://bugzilla.gnome.org/review?bug=626618&attachment=174667)

::: gst/jpegformat/gstjpegparse.c
@@ +604,3 @@
+  GST_MEMDUMP ("comment", data, size);
+  if (s && !g_utf8_validate (s, size, NULL))
+    return NULL;

I have done quite some research on that and as far as I know this is just
ascii. Have you found any spec saying that this is UTF8? Sure, valid ascii is
also valid utf8.

@@ +640,3 @@
+        parse->priv->srcpad, tags);
+
+    g_slice_free (char, comment);

I think this is not correct - it would need to be e.g. char[20]. I would just
use an ordinary g_strdup above and g_free here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.