[gstreamer-bugs] [Bug 632885] Gaudi Effects dynamically controllable parameters [review]

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632885
  GStreamer | gst-plugins-bad | git

--- Comment #8 from Luis de Bethencourt <luisbg at ubuntu.com> 2010-10-23 20:32:38 UTC ---
(In reply to comment #6)
> Review of attachment 173011 [details]:
> 
> This patch does not do what it claims to do, it adds some properties to random
> effects.
> 
> (But you should base the effect elements on GstVideoFilter instead of
> GstBaseTransform)
> 
> Please change the commit message and fix the gstplugin.h changes
> 
> ::: gst/gaudieffects/gstplugin.h
> @@ -3,3 @@
>   * Copyright (C) 2005 Thomas Vander Stichele <thomas at apestaart.org>
>   * Copyright (C) 2005 Ronald S. Bultje <rbultje at ronald.bitfreak.net>
> - * Copyright (C) 2010 Luis de Bethencourt <luis at debethencourt.com>
> 
> This change looks inverted
> 
> @@ -48,1 @@
> 
> 
> And this one too and everything else in this file

I see what you mean. Sorry about the commit message, I confused the difference
with my previous version with the one Jan submitted to gst-plugins-bad.
I will fix it, and also clean the changes on gstplugin.h.

I will look into basing the effects on GstVideoFilter instead of
GstBaseTransform.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.