[gstreamer-bugs] [Bug 632885] Gaudi Effects dynamically controllable parameters [review]

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632885
  GStreamer | gst-plugins-bad | git

--- Comment #9 from Luis de Bethencourt <luisbg at ubuntu.com> 2010-10-23 20:35:26 UTC ---
(In reply to comment #7)
> Review of attachment 173012 [details]:
> 
> Looks good in general... any reason why you only make some properties
> controllable... and only some elements?

I gave higher priority to the properties that have a bigger impact on the
outcome.

> 
> you should also call gst_controller_init() in gstplugin.c
> 

Will do.

> ::: gst/gaudieffects/gstchromium.h
> @@ -72,3 @@
>    GstVideoFilter videofilter;
> -
> -  /* < private > */
> 
> You should keep this comment, otherwise gtk-doc will show it

Ooooh, didn't thought about that. Cool.

Thanks a lot for the review! :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.