[Bug 642730] New features for AAC and other passthrough support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=642730
  GStreamer | gst-plugins-base | 0.10.17

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185929|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge <slomo at circular-chaos.org> 2011-04-14 07:56:58 UTC ---
Review of attachment 185929:
 --> (https://bugzilla.gnome.org/review?bug=642730&attachment=185929)

::: gst-libs/gst/audio/gstbaseaudiosink.c
@@ +1716,3 @@
+done:
+  if (out)
+    gst_buffer_unref (out);

Does this unref here make sense if it is done only for the case when payloading
was done? Shouldn't that buffer always be unreffed or never?

@@ +1733,3 @@
+payload_failed:
+  {
+    GST_DEBUG_OBJECT (sink, "failed to payload data for iec958 transmission");

This is not only for IEC958 I suppose? Just remove it from the debug output :)

::: gst-libs/gst/audio/gstbaseaudiosink.h
@@ +145,3 @@
+ *           payloading is required, returns a reffed copy of the original
+ *           buffer, else returns the payloaded buffer with all other metadata
+ *           copied.

Please add here that the subclass is supposed to take ownership of the passed
buffer

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.