[Bug 642730] New features for AAC and other passthrough support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=642730
  GStreamer | gst-plugins-base | 0.10.17

--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org> 2011-04-14 08:01:02 UTC ---
Review of attachment 185928:
 --> (https://bugzilla.gnome.org/review?bug=642730&attachment=185928)

Looks good in general, just some minor things

::: gst-libs/gst/audio/gstaudioiec61937.c
@@ +45,3 @@
+
+  /* We're assuming caps has only one structure. This should be fair since we
+   * don't expect a GstRingBufferSpec to carry buffers with multiple formats
*/

GstRingBufferSpec can only have fixed caps anyway

::: gst-libs/gst/audio/gstaudioiec61937.h
@@ +2,3 @@
+ * (c) 2011 Intel Corporation
+ *          Collabora Multimedia
+ *          Arun Raghavan <arun.raghavan at collabora.co.uk>

We usually use
Copyright (C) YEAR NAME

and multiple lines for multiple copyright holders

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.