[Bug 655719] wayland video sink: initial implementation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=655719
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ensonic at sonicpulse.de

--- Comment #5 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-08-10 12:08:12 UTC ---
I would have some naming nitpicks:

typedef struct _GstWayLandSink GstWayLandSink;

only use camer case for separate words. that is just call it GstWaylandSink
("wayland" is one name and not "way land" to my knowledge).


in the header you have
typedef struct wl_display WlDisplay;
typedef struct wl_buffer WlBuffer;
and then
struct  display { ... }
struct  window { ... }

some copy'n'paste bugs? is the wl_buffer thing meant to be the window and is
the "wl_" prefix missing on the structs?

in the c-file I saw a  g_usleep (50000), that I hope you will replace. Always
good to add FIXME comments for the things you know that are WIP.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.