[gstreamer-bugs] [Bug 629196] Tagging an Ogg Vorbis file may corrupt audio data

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=629196
  GStreamer | gst-plugins-base | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178921|none                        |committed
             status|                            |

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-02-01 17:28:04 UTC ---
(From update of attachment 178921)
Committed with small addition to improve re-usability (state change PLAYING ->
NULL ->PLAYING):

@@ -1607,6 +1613,7 @@ gst_ogg_mux_init_collectpads (GstCollectPads * collect)
     oggpad->new_page = TRUE;
     oggpad->first_delta = FALSE;
     oggpad->prev_delta = FALSE;
+    oggpad->data_pushed = FALSE;
     oggpad->pagebuffers = g_queue_new ();

     walk = g_slist_next (walk);



commit b7664eae716a7e0026c3d4d7ca10897a30f6a45e
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Fri Jan 21 10:56:00 2011 +0000

    oggmux: do not skip a pageno at start

    Discontinuities are automatically signalled by oggdemux at the start
    of a new stream. When oggmux is yet to output actual data pages,
    do not signal these discontinuities in the ogg stream.

    This patch may miss some actual discontinuities at the very start of
    a stream, but avoids the spurious missing pages when encoding happens
    normally.

    A better fix might involve finding a way to distinguish between actual
    data discontinuities and discontinuities merely marking the start of
    a new stream.

    Fixes an issue with ogg page numbering (would skip a number for no
    reason, which then looks like a packet was lost somewhere) when
    re-muxing an ogg stream, e.g. when re-tagging in rhythmbox.

    https://bugzilla.gnome.org/show_bug.cgi?id=629196

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.