[gstreamer-bugs] [Bug 622553] rtpmanager: Implement RFC 4585 (AVPF / early feedback)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=622553
  GStreamer | gst-plugins-good | git

--- Comment #5 from Wim Taymans <wim.taymans at gmail.com> 2011-02-01 18:04:29 UTC ---
I reviewed and merged the branch, it all looked good. These are some comments
that probably need to be cleared up before the release:

* the on-sending-rtcp signal uses gpointer for the buffer, might use a 
  miniobject too (is a bit more annoying to generate the marshaller but 
  presumably handles the refcount better).

* the on-feedback-rtcp partially parses the FB RTCP packet and puts various
bits
  in the signal arguments. Would we do it like this or simply pass the buffer,
  like in on-sending-rtcp? how is this function used, mostly?

* rtp_session_process_feedback() lots of peeking into the private bits of 
  GstRTCPPacket. Can we use the public functions instead? maybe we need some
  helper functions?

* gst_rtp_session_request_time() returns the absolute systemclock time. Is this
  right? I have not looked closer at what clock is used to compare against.

* something is wrong with commit 1bde4272509c30f0818af865c2f8f51014f7ac14.
  I commited a patch to fix this commit (there was a bracket too much
somewhere)
  to something that makes sense to me but you want to recheck if this is what
  you intended.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.