[Bug 627459] theoraenc should provide option for TH_ENCCTL_SET_DUP_COUNT

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627459
  GStreamer | gst-plugins-base | 0.10.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189205|none                        |needs-work
             status|                            |

--- Comment #42 from Sebastian Dröge <slomo at circular-chaos.org> 2011-06-26 13:53:18 UTC ---
Review of attachment 189205:
 --> (https://bugzilla.gnome.org/review?bug=627459&attachment=189205)

Some typos in the commit message and elsewhere

Also I think you keep the last buffer queued and don't encode/dequeue them on
EOS.

::: ext/theora/gsttheoraenc.c
@@ +427,3 @@
+          "This is goot to work with variable frame rate stabelized "
+          "by videorate element, but may be not good for other things "
+          "like rtp stream.",

Typos: "duplicates", "good", "stabilized", "streams"
Say something about live streams instead of just RTP

@@ +1215,3 @@
+{
+  if (enc->dup_on_gap) {
+    guint lenght;

length

@@ +1219,3 @@
+    lenght = g_queue_get_length (enc->t_queue);
+
+    /* there is some thing really bad if lenght is smaller than 1 */

length

@@ +1237,3 @@
+    g_queue_free (enc->t_queue);
+  }
+  /* prevbuf make no sence without timestamps, 

"sense" and "makes"

@@ +1315,3 @@
+    theora_enc_init_buffer (ycbcr, &enc->info, GST_BUFFER_DATA (buffer));
+
+    if (theora_enc_is_discontinuous (enc, running_time, duration)) {

What exactly is the reason now, why the discont detection happens with the dup
frames but not in normal mode?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.