[Bug 597822] Add removesilence plugin

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Jun 26 06:59:30 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=597822
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190077|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge <slomo at circular-chaos.org> 2011-06-26 13:59:19 UTC ---
Review of attachment 190077:
 --> (https://bugzilla.gnome.org/review?bug=597822&attachment=190077)

Looks good in general but:

::: gst/removesilence/gstremovesilence.c
@@ +240,3 @@
+    if (filter->remove) {
+      GST_DEBUG ("Removing silence");
+      return GST_BASE_TRANSFORM_FLOW_DROPPED;

Note that this doesn't result in continous timestamps/durations. You're just
dropping the buffer here while (from what you've written before) you want the
next buffer to replace it. In that case you have to adjust all following
timestamps after dropping the first buffer by the accumulated duration of all
buffers.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list