[Bug 643775] [oggmux] use running time instead of timestamps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=643775
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182335|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-03-03 14:25:44 UTC ---
Review of attachment 182335:
 --> (https://bugzilla.gnome.org/review?bug=643775&attachment=182335)

::: ext/ogg/gstoggmux.c
@@ +326,2 @@
   switch (GST_EVENT_TYPE (event)) {
+    case GST_EVENT_NEWSEGMENT:{

You also need to reset (i.e. re-init) the segment on flush-stop

::: ext/ogg/gstoggmux.h
@@ +54,3 @@
   gboolean have_type;

+  GstSegment *segment;

Just store it as GstSegment instead of GstSegment*, saves one allocation and
the possibility to create a memory leak later ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.