[Bug 644150] [basevideoencoder] Store the GstForceKeyUnit event for forwarding it later

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=644150
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier.crete at ocrete.ca

--- Comment #2 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2011-03-07 20:37:45 UTC ---
quick comments:

s/g_print/GST_DEBUG/

Unreffing the event should be done in dispose, not finalize (it could have a
ref to another GObject)

Set "base_video_encoder->force_key_unit_event" to NULL after sending it (just
to be safe. You probably want to clear it on flushes and the like.

In the src_event function, you keep a pointer to the event, but not a ref... 

Also, when sending it out, you may want to set the timestamp, running-time,
stream-time (if you have them),

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.