[Bug 644150] [basevideoencoder] Store the GstForceKeyUnit event for forwarding it later

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=644150
  GStreamer | gst-plugins-bad | git

--- Comment #3 from Andoni Morales <ylatuya at gmail.com> 2011-03-07 20:46:15 UTC ---
(In reply to comment #2)
> quick comments:
> 
> s/g_print/GST_DEBUG/

My mistake, this shouldn't be there.
> 
> Unreffing the event should be done in dispose, not finalize (it could have a
> ref to another GObject)
Right
> 
> Set "base_video_encoder->force_key_unit_event" to NULL after sending it (just
> to be safe. You probably want to clear it on flushes and the like.
ok
> 
> In the src_event function, you keep a pointer to the event, but not a ref... 
The ref is kept by not unrefing, as it was done before.
> 
> Also, when sending it out, you may want to set the timestamp, running-time,
> stream-time (if you have them),
As I can see in the draft, this should be defined in the event's structure
right?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.