[Bug 662775] dv1394src: Add support for old kernels

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=662775
  GStreamer | gst-plugins-good | git

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200033|none                        |needs-work
             status|                            |

--- Comment #4 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-11-08 11:39:59 UTC ---
Review of attachment 200033:
 --> (https://bugzilla.gnome.org/review?bug=662775&attachment=200033)

The patch does not add tests for the conditions your commit message mentions
(2.6.24, 2.6.21),
should those be added to configure (or in the source) ?

::: ext/raw1394/gst1394clock.c
@@ +129,3 @@
+            CSR_REGISTER_BASE | CSR_CYCLE_TIME,
+            sizeof (guint32), cycle_timer) == 0) {
+      *cycle_timer = GUINT32_SWAP_LE_BE (*cycle_timer);

That looks a bit suspicious. The hardware is returning something in a fixed
endianness presumably, this will yield a value in a fixed endianness as well,
should it not be swapped only on BE or LE ?

@@ +186,3 @@
   clock->cycle_timer_hi = 0;
+
+  if (raw1394_read_cycle_timer (clock->handle, &cycle_timer, &local_time) !=
0) {

That function is declared as returning a boolean, not an int.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.