[Bug 660598] playbin2: Make sure that elements that are plugged are compatible with the fixed sink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660598
  GStreamer | gst-plugins-base | 0.10.x

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-10-03 08:30:31 UTC ---
Review of attachment 197918:
 --> (https://bugzilla.gnome.org/review?bug=660598&attachment=197918)

::: gst/playback/gstplaybin2.c
@@ +3231,3 @@
+    /* If it is not a video element and we don't have a fixed video sink
+     * we try the factory */
+    if (!strstr (klass, "Video") || !group->video_sink) {

Also use the gst_element_factory_list_is_type() API here with MEDIA_VIDEO and
MEDIA_IMAGE  (and for audio with MEDIA_AUDIO) instead of the manual comparison.

@@ +3242,3 @@
+        caps = gst_pad_get_caps (sinkpad);
+
+        compatible = gst_element_factory_can_src_any_caps (factory, caps);

Do this compatibility check only for GST_ELEMENT_FACTORY_TYPE_DECODER,
otherwise you'll never plug parsers or demuxers anymore

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.