[Bug 660528] kate: rendering performance improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660528
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197928|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2011-10-03 08:43:26 UTC ---
Review of attachment 197928:
 --> (https://bugzilla.gnome.org/review?bug=660528&attachment=197928)

::: ext/kate/gstkatetiger.c
@@ +156,3 @@
+
+#if G_BYTE_ORDER == G_LITTLE_ENDIAN
+# define CAIRO_ARGB_A 3

We're not using cairo here ;)

@@ +183,3 @@
 #define TIGER_VIDEO_CAPS \
     GST_VIDEO_CAPS_xRGB ", endianness = (int)1234; " \
+    GST_VIDEO_CAPS_BGRx ", endianness = (int)4321;" \

Erm, you shouldn't specify endianness here. GST_VIDEO_CAPS_xRGB and friends
already include this field with the correct value.

Note that xRGB with endianness 1234 would be the same as BGRx with endianness
4321. And that we only use big endian endianness for 24/32 bpp RGB formats in
the caps anyway and specify the order of components with the masks.

@@ +767,3 @@

+static inline void
+gst_kate_tiger_blit_1 (GstKateTiger * tiger, guchar * dest, gint xpos,

Did you take the YUV rendering functions from another plugin? They look
familiar to me :) If you did, maybe add some comment about this here and/or
mention copyright holders of the original code, etc.
If you didn't copy them, ignore this comment :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.