[Bug 667655] test/checks/elements/jifmux.c compile failure because of fail() calls with no arguments

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jan 11 06:34:05 PST 2012


https://bugzilla.gnome.org/show_bug.cgi?id=667655
  GStreamer | gst-plugins-bad | 0.10.22

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #1 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2012-01-11 14:34:01 UTC ---
You appear not to be using GCC, from looking at the arguments to cc, and fail
uses a GCC extension (##), which will remove the extraneous comma if the
varargs are empty.
The jifmux test is the only piece of code I can see which uses the fail call,
and every time without any arguments, so maybe fail could be changed to not
allow any arguments, eg:

#define fail() _fail_unless(0, __FILE__, __LINE__, "Failed" , NULL)

That might break external code, if any actually uses varargs here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list