[Bug 667655] test/checks/elements/jifmux.c compile failure because of fail() calls with no arguments

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jan 11 15:07:14 PST 2012


https://bugzilla.gnome.org/show_bug.cgi?id=667655
  GStreamer | gst-plugins-bad | 0.10.22

--- Comment #2 from Tim Mooney <mooney at dogbert.cc.ndsu.nodak.edu> 2012-01-11 23:07:08 UTC ---
You're right, as I mentioned at the top of the ticket, I'm using the no-cost
Sun/Oracle Studio compiler toolchain.

I didn't realize that ## is a gcc-only extension.  It would be really nice to
fix this at the source; make fail() work for both gcc and non-gcc, even if it
means something like

#if defined(__GNUC__)
# define fail current_implementation
#else
# define fail some_alternate_implementation
#endif

I've been doing some reading on check, and it looks like the
fail/fail_if/fail_unless interface may be deprecated in favor of the
ck_abort/ck_abort_msg/ck_assert/ck_assert_msg API.

I'll keep looking at check() to see if I can come up with something better that
might be accepted upstream too.

In the meantime, I just hacked jifmux.c so that fail() is always called as
fail("").

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list