[Bug 669127] New: Use embedded AUTOMOC feature of CMake (>= 2.8.6) to reduce our external dependencies

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jan 31 10:17:48 PST 2012


https://bugzilla.gnome.org/show_bug.cgi?id=669127
  GStreamer | qt-gstreamer | git

           Summary: Use embedded AUTOMOC feature of CMake (>= 2.8.6) to
                    reduce our external dependencies
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: qt-gstreamer
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: joaopizani at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=206539)
 View: https://bugzilla.gnome.org/attachment.cgi?id=206539
 Review: https://bugzilla.gnome.org/review?bug=669127&attachment=206539

Patch to the CMakeList files removing the external dependency on automoc

Today I was trying to compile qt-gstreamer from git, and, since I have also
built my own version of Qt (4.8.0), I was very reluctant to have to install
automoc (and thus Qt libraries) again...

Then I browsed the interwebs a bit, and found out that, from CMake 2.8.6
onwards, there is an EMBEDDED automoc feature, so that we don't need to depend
on an external automoc executable anymore.

I quickly patched all lines in all CMakeList's that involved automoc4_add_* to
add_* and proceeded to build qt-gstreamer.

It was built with no errors, the test suite ran fine and I could run my own
application using qt-gstreamer also without any problems...

I think it's reasonable to start requiring CMake 2.8.6 or greater, since it was
launched last October, and we have already CMake 2.8.7. Plus, the upcoming
Ubuntu (12.04 LTS) will already include CMake 2.8.6...

So, why not sending the patch upstream? :)

In the attachment you can find the patch, as given by the output of "git
format-patch -1". Enjoy :D

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list