[Bug 638168] textoverlay: don't return wrong-state when stopping while in text chain

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=638168
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213764|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge <slomo at circular-chaos.org> 2012-05-10 13:35:50 UTC ---
Review of attachment 213764:
 --> (https://bugzilla.gnome.org/review?bug=638168&attachment=213764)

Looks good, other than Vincent's comments:

::: ext/pango/gsttextoverlay.c
@@ +1996,2 @@
           GST_OBJECT_UNLOCK (overlay);
+          ret = GST_FLOW_WRONG_STATE;

This is just reverting Vincent's patch, right? Which is not in GStreamer GIT

::: gst/playback/gstsubtitleoverlay.c
@@ +580,3 @@
+  /* always push newsegment with format TIME */
+  tformat = GST_FORMAT_TIME;
+  res = gst_pad_query_convert (peer, segment->format, segment->accum,
&tformat, &taccum);

Only do conversions if not in TIME format already. Conversion of -1 values is
not necessary either. And the peer could be NULL.

@@ +2146,3 @@
+
+        tformat = GST_FORMAT_TIME;
+        res = gst_pad_query_convert (peer, format, start, &tformat, &tstart);

Same comments as above

::: gst/subparse/gstsubparse.c
@@ +1643,3 @@

+      /* make sure the newsegment is pushed to the srcpad in
gst_sub_parse_chain */
+      self->need_segment = TRUE;

Is subparse creating a new event from the segment or passing through the
upstream event if in TIME format? If it creates a new one, it really shouldn't
do that for several reasons

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.