[Bug 672701] mpegvideoparse: high cpu usage breaks playback of mpeg2 video in mkv on dreambox

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=672701
  GStreamer | gst-plugins-bad | 0.10.23

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213760|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2012-05-10 13:40:21 UTC ---
Review of attachment 213760:
 --> (https://bugzilla.gnome.org/review?bug=672701&attachment=213760)

Doesn't look wrong but do you also have some numbers (just curious :) )? And do
the addition of new branches in the code really improve performance that much,
especially as this doesn't look very friendly to branch prediction? Might make
sense to use lookup table maybe?

Couldn't you use the byte reader scanning function here instead (and optimize
that the same way?)?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.