[Bug 638168] textoverlay: don't return wrong-state when stopping while in text chain

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=638168
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213880|none                        |reviewed
             status|                            |

--- Comment #23 from Sebastian Dröge <slomo at circular-chaos.org> 2012-05-14 07:42:06 UTC ---
Review of attachment 213880:
 --> (https://bugzilla.gnome.org/review?bug=638168&attachment=213880)

::: gst/playback/gstplaysink.c
@@ +1863,3 @@
+    playsink->text_flush = FALSE;
+    GST_PLAY_SINK_UNLOCK (playsink);
+    gst_pad_send_event (pad, gst_event_new_flush_stop ());

This might cause problems if the flush-stop event reaches the other side of the
subtitleoverlay, due to resetting the segments and other state. This doesn't
happen here?

Also should this really be gst_pad_send_event() and not gst_pad_push_event()?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.