[Bug 676003] fails to pull in push mode due to check for already activated pad removed

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon May 14 03:57:04 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=676003
  GStreamer | gstreamer (core) | 0.11.x

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.11.x

--- Comment #5 from Wim Taymans <wim.taymans at gmail.com> 2012-05-14 10:56:58 UTC ---
commit 10396f12d43ed7d7b10aae556ba1b2a2ec4e6cba
Author: Alban Browaeys <prahal at yahoo.com>
Date:   Mon May 14 03:57:50 2012 +0200

    typefindelement: if sink pad is activated do not change mode

    In commit bf0964b6 a check for pad is activated was not carried.
    This leads to attempt to pull while in push mode when force_caps
    is set. In this case without the attached check even when activated
    in pull mode we activate back to push mode.

    This is from comment in previous code , case number eight:
     8. if the sink pad is activated, we are in pull mode. succeed.
    -     otherwise activate both pads in push mode and succeed.

    Putting it back fixes playback of webm in webkit+gstreamer 1.0 .

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=676003

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list