[Bug 684251] deinterlace: Bug in logic in _output_frame causing incorrect behaviour?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684251
  GStreamer | gst-plugins-good | git

Jan Schmidt <thaytan> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com

--- Comment #1 from Jan Schmidt <thaytan at mad.scientist.com> 2012-09-17 22:53:24 UTC ---
Here's the output I get with current git:

renderer:src segment: rate 1 format 3, start: 0:00:10.000000000, stop:
99:99:99.999999999, time: 0:00:00.000000000 base: 0:00:00.000000000
renderer:src Buffer PTS 0:00:10.000000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.000000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.060000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.040000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.100000000 duration 0:00:00.020000000
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
New clock: GstPulseSinkClock
renderer:src Buffer PTS 0:00:10.080000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.140000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.120000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.180000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.160000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.220000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.200000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.260000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.240000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.300000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.280000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.340000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.320000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.380000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.360000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.420000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.400000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.460000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.440000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.500000000 duration 0:00:00.020000000
renderer:src Buffer PTS 0:00:10.480000000 duration 0:00:00.020000000
WARNING: from element
/GstPlayBin:playbin0/GstPlaySink:playsink/GstBin:vbin/GstAutoVideoSink:videosink/GstXvImageSink:videosink-actual-sink-xvimage:
A lot of buffers are being dropped.
Additional debug info:
gstbasesink.c(2671): gst_base_sink_is_too_late ():
/GstPlayBin:playbin0/GstPlaySink:playsink/GstBin:vbin/GstAutoVideoSink:videosink/GstXvImageSink:videosink-actual-sink-xvimage:

If I delete lines 1841-1843, then the timestamps are correct.

diff --git a/gst/deinterlace/gstdeinterlace.c
b/gst/deinterlace/gstdeinterlace.c
index bb4022e..d0f22b2 100644
--- a/gst/deinterlace/gstdeinterlace.c
+++ b/gst/deinterlace/gstdeinterlace.c
@@ -1838,10 +1838,6 @@ restart:
   if (self->cur_field_idx < 0)
     return ret;

-  if (!flushing && self->cur_field_idx < 1) {
-    return ret;
-  }
-
   /* deinterlace bottom_field */
   if ((self->field_history[self->cur_field_idx].flags ==
           PICTURE_INTERLACED_BOTTOM && (self->fields == GST_DEINTERLACE_BF

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.