[Bug 684251] deinterlace: Bug in logic in _output_frame causing incorrect behaviour?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684251
  GStreamer | gst-plugins-good | git

Robert Swain <robert.swain> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Robert Swain <robert.swain at gmail.com> 2012-09-18 22:43:47 UTC ---
commit 480b894642abf0267839c44257fe9351f987ce50
Author: Robert Swain <robert.swain at collabora.co.uk>
Date:   Wed Sep 19 00:39:01 2012 +0200

    deinterlace: Remove incorrect logic

    I don't understand why these lines were added, they don't make sense to
    me now and both David and I agree that removing them moves closer to
    related logic being correct, therefore, they're being removed.

    I've tested a few progressive, interlaced and telecine clips and they
    all behave properly timestamp-wise and visually after these changes.

commit a35a9315556c9a3477cbf86fc4e79fdc05b1c182
Author: Robert Swain <robert.swain at collabora.co.uk>
Date:   Wed Sep 19 00:17:49 2012 +0200

    deinterlace: Fix field duration

    The frame rate fraction is correctly adjusted in the cases preceding the
    field duration calculation and so the factor of 2 is incorrect.

Those should really be attributed to Jan but he didn't commit them and Tim
urged me to commit so... :)

I've tested a bit with various clips and everything seems to behave well. At
least in the default cases. I tested pattern locking more before I think.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.