[Bug 684237] videomixer: Caps negotiation does not always work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684237
  GStreamer | gst-plugins-good | git

Michael Rubinstein <mrubinstein> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrubinstein at weather.com

--- Comment #17 from Michael Rubinstein <mrubinstein at weather.com> 2012-09-26 12:47:50 UTC ---
(In reply to comment #10)
> The three last patches should fix the remaining issues. It took me a while to
> understand the gst_video_info_to_caps() was adding extra fields to the caps set
> downstream, causing is_subset() to fail in different upstream elements.
> Reviewer can also pull from:
> 
> http://cgit.collabora.com/git/user/nicolas/gst-plugins-good.git/log/?h=videomixer-fixup

I needed to make one more change to fix the problem in my environment.

In videomixer2.c:gst_videomixer2_pad_sink_getcaps

change:
      gst_structure_set (s, "pixel-aspect-ratio", GST_TYPE_FRACTION, 1, 1,
          NULL);

to:
      gst_structure_set (s, "pixel-aspect-ratio", GST_TYPE_FRACTION_RANGE, 1,
G_MAXINT, G_MAXINT, 1, 
          NULL);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.