[Bug 684237] videomixer: Caps negotiation does not always work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684237
  GStreamer | gst-plugins-good | git

--- Comment #18 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2012-09-26 13:38:27 UTC ---
(In reply to comment #17)
> (In reply to comment #10)
> 
> I needed to make one more change to fix the problem in my environment.
> 
> In videomixer2.c:gst_videomixer2_pad_sink_getcaps
> 
> change:
>       gst_structure_set (s, "pixel-aspect-ratio", GST_TYPE_FRACTION, 1, 1,
>           NULL);
> 
> to:
>       gst_structure_set (s, "pixel-aspect-ratio", GST_TYPE_FRACTION_RANGE, 1,
> G_MAXINT, G_MAXINT, 1, 
>           NULL);

Good to know, but can we have a bit more context, so we actually understand why
is this needed. When I first saw that code, I thought I should have simply
removed it, would that also work for you ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.