[Bug 697103] [PATCH] osxaudio: port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697103
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241577|none                        |needs-work
             status|                            |

--- Comment #31 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-16 10:54:58 UTC ---
Review of attachment 241577:
 --> (https://bugzilla.gnome.org/review?bug=697103&attachment=241577)

Looks good in general, just:

::: sys/osxaudio/gstosxaudioringbuffer.c
@@ +229,3 @@
       CORE_AUDIO_FORMAT_ARGS (format));

+  osxsink = GST_OSX_AUDIO_SINK (GST_OBJECT_PARENT (buf));

Yes, that part will fail for the source. GST_IS_OSX_AUDIO_SINK() can help
here... but similar code should probably also be added for the source here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.