[Bug 702327] h264parse: Fixate to upstream format when possible

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Aug 15 01:10:11 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=702327
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251695|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-15 08:10:08 UTC ---
Review of attachment 251695:
 --> (https://bugzilla.gnome.org/review?bug=702327&attachment=251695)

::: code/Gstreamer/gstreamer-1.0.8/gsth264parse.c
@@ +350,3 @@
+    const char *ai1_stream_format[3] = {"unknown", "avc", "byte-stream"};
+
+    src_caps_st = gst_caps_get_structure (caps, 0);

The caps can have multiple structures here

AFAIU you could just loop over all structures, and for each structure call
gst_structure_fixate_field_string(s, "stream-format", upstream_stream_format).
That will chose the upstream stream format if possible, otherwise chose one of
the possible ones.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list