[Bug 691462] typefind ADTS/AAC wrongly detected as MP2

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=691462
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251622|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-15 08:13:10 UTC ---
Review of attachment 251622:
 --> (https://bugzilla.gnome.org/review?bug=691462&attachment=251622)

::: gst/typefind/gsttypefindfunctions.c
@@ +1085,3 @@
         }

         gst_type_find_suggest (tf, GST_TYPE_FIND_LIKELY, caps);

Just call gst_type_find_suggest() once in the end and not for every single try

@@ +1104,3 @@
+              (c.data[offset + 4] << 3) | ((c.data[offset + 5] & 0xe0) >> 5);
+          if (len == 0 || !data_scan_ctx_ensure_data (tf, &c, len + 2)) {
+            GST_DEBUG ("Wrong sync or next frame not within reach, len=%u",
len);

I'd say if not enough data is available you should not goto next but return
whatever probability you have accumulated so far

@@ +1109,3 @@
+          snc = GST_READ_UINT16_BE (c.data + offset);
+          if ((snc & 0xfff6) == 0xfff0) {
+            gst_type_find_suggest (tf, GST_TYPE_FIND_LIKELY + 5 * (i - 2),
caps);

Same here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.