[Bug 705079] hlsdemux: switch fragments to buffer lists to avoid copies

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705079
  GStreamer | gst-plugins-bad | 1.1.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250627|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-19 10:49:36 UTC ---
Review of attachment 250627:
 --> (https://bugzilla.gnome.org/review?bug=705079&attachment=250627)

Looks generally good.

Could you, on top of that, provide patches to at least one of the elements
(hlsdemux probably then? :) ) that uses the new bufferlist functionality?

::: gst-libs/gst/uridownloader/gstfragment.c
@@ -37,3 @@
   PROP_DURATION,
   PROP_DISCONTINOUS,
-  PROP_BUFFER,

Keep the buffer property if you keep get_buffer() too

@@ +310,3 @@
+
+    if (n_blocks <= gst_buffer_get_max_memory ()) {
+      last_buffer = gst_buffer_append (last_buffer, buffer);

I think you should adjust GST_BUFFER_OFFSET() and GST_BUFFER_OFFSET_END() here
when appending memories

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.