[Bug 706779] oggmux: support flushing seeks

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Aug 28 22:30:15 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=706779
  GStreamer | gst-plugins-base | git

Alessandro Decina <alessandro.d> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253349|0                           |1
        is obsolete|                            |

--- Comment #8 from Alessandro Decina <alessandro.d at gmail.com> 2013-08-29 05:30:09 UTC ---
Created an attachment (id=253468)
 View: https://bugzilla.gnome.org/attachment.cgi?id=253468
 Review: https://bugzilla.gnome.org/review?bug=706779&attachment=253468

new patch

New patch that changes the FLUSH_STOP logic a little. Instead of sending
FLUSH_STOP from the first _collected() call after a flush, we now send
FLUSH_STOP right after flushing. This way oggmux:src and downstream are ready
to process events/data immediately. Buffers will still resume traveling
downstream again after all upstreams have finished flushing, but events that
are not queued by collectpads (like _TAG events), will be able to be pushed by
the upstream elements that have finished flushing (possibly while some instead
are still flushing), without things failing because oggmux:src is flushing.

...or just look at gst_ogg_mux_flush in the patch.

This patch is functional now and i'll try to add a test. In the meantime, can
anyone spot anything obviously wrong?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list