[Bug 706779] oggmux: support flushing seeks

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Aug 29 01:30:17 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=706779
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253468|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-29 08:30:13 UTC ---
Review of attachment 253468:
 --> (https://bugzilla.gnome.org/review?bug=706779&attachment=253468)

Maybe there should be some collectpads API to make this more easy, also for
other elements?

::: ext/ogg/gstoggmux.c
@@ +369,3 @@
+      if (g_atomic_int_compare_and_exchange (&ogg_mux->pending_flush, TRUE,
+              FALSE)) {
+        gst_ogg_mux_flush (ogg_mux);

This now sends flush-stop from the thread that called flush-start. flush-start
is OOB, so can happen from any thread. flush-stop is serialized and must happen
from the streaming thread and with the srcpad stream lock.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list