[Bug 693826] add dmabuf support in -good

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693826
  GStreamer | gst-plugins-good | 1.0.5

--- Comment #8 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-15 10:09:16 UTC ---
Review of attachment 236225:
 --> (https://bugzilla.gnome.org/review?bug=693826&attachment=236225)

Actually the allocator should be a singleton, so you should have a GstAllocator
*gst_dmabuf_allocator_obtain()

::: gst/dmabuf/gstdmabuf.c
@@ +142,3 @@
+} dmabuf_mem_AllocatorClass;
+
+GType dmabuf_mem_allocator_get_type (void);

The get_type() function should probably be in the header too, and a opaque
definition of GstDmaBufAllocator

@@ +183,3 @@
+
+  if (!_dmabuf_mem_type_initialized)
+    dmabuf_mem_init ();

Also this is not threadsafe

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.