[Bug 693826] add dmabuf support in -good

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693826
  GStreamer | gst-plugins-good | 1.0.5

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236225|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-15 10:02:48 UTC ---
Review of attachment 236225:
 --> (https://bugzilla.gnome.org/review?bug=693826&attachment=236225)

Should still be in a core or base library

::: gst/dmabuf/gstdmabuf.c
@@ +74,3 @@
+  if (res) {
+    /* only return address if mapping flags are equivalent */
+    if (mem->mmapping_flags == prot)

Don't really need to be equivalent, right? But the new flags should be a subset
of the old ones, and if it was write-mapped it shouldn't be able to map again
This needs some locking btw

::: gst/dmabuf/gstdmabuf.h
@@ +34,3 @@
+} GstDmaBufMemory;
+
+GstMemory * gst_dmabuf_allocator_new (gint fd , gsize size);

I talked with Wim about this and that was the conclusion:
- Have an opaque GstDmaBufMemory type and gint gst_dmabuf_memory_get_fd(mem)
- Have a constructor for a generic dmabuf allocator (GstAllocator *
gst_dmabuf_allocator_new(void)) and GstMemory *
gst_dmabuf_allocator_alloc(allocator, fd, size, params, ...)
- No GstMeta or anything

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.