[Bug 694068] h264parser: Parse the cropping-rectangle separately.

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jul 5 03:01:55 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=694068
  GStreamer | gst-plugins-bad | git

--- Comment #4 from sreerenj <bsreerenj at gmail.com> 2013-07-05 10:01:52 UTC ---
(In reply to comment #3)
> Review of attachment 236561 [details]:
> 
> This will need a change in h264parse if I understand correctly, as h264parse
> currently uses sps->width/height for the caps. Instead it should now use the
> cropped width/height.
> 
> Otherwise looks good to me, will push after the corresponding h264parse change.

The patch is setting the un_cropped values to sps->width/sps->height. We are
supposed to set the cropping values as videometa (instead of setting the
cropped values to caps) since it is the duty of renderer to deal with cropping.
right?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list