[Bug 704070] video: Add Region Of Interest (roi) meta

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704070
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249212|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-16 07:05:09 UTC ---
Review of attachment 249212:
 --> (https://bugzilla.gnome.org/review?bug=704070&attachment=249212)

Almost :)

::: gst-libs/gst/video/gstvideometa.c
@@ +1,1 @@
+/*

Why did you remove this? :)

@@ +536,3 @@
+{
+  static volatile GType type;
+  static const gchar *tags[] = { "location", " size", NULL };

This should be orientation and size, location has no meaning yet. What do you
mean with location here?

@@ +594,3 @@
+{
+  GstVideoRegionOfInterestMeta *emeta = (GstVideoRegionOfInterestMeta *) meta;
+  emeta->x = emeta->y = emeta->w = emeta->h = 0;

Initialize the other fields too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.